No longer wrap and run ct in Docker container #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this major change, the action no longer wraps and runs ct in a Docker container but simply installs it directly on the host. Default config files that are part of the distro and Yamale and yamllint are installed as well. With this change, ct is directly exposed to the user with all options directly available. It will be much easier now to integrate custom tools using the new feature to run additional commands introduced in #283. Signed-off-by: Reinhard Nägele <[email protected]>
|
/cc @torstenwalter |
Signed-off-by: Reinhard Nägele <[email protected]>
davidkarlsen
reviewed
Nov 2, 2020
scottrigby
approved these changes
Nov 2, 2020
There was a problem hiding this comment.
I saw the initial test for this and liked it. This PR looks right to me, though I haven't ever uses custom runners, so I'd defer to @davidkarlsen on that. Barring that, lgtm 💯
Signed-off-by: Reinhard Nägele <[email protected]>
davidkarlsen
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this major change, the action no longer wraps and runs ct in a Docker
container but simply installs it directly on the host. Default config
files that are part of the distro and Yamale and yamllint are installed as
well.
With this change, ct is directly exposed to the user with all options
directly available. It will be much easier now to integrate custom tools
using the new feature to run additional commands introduced in
helm/chart-testing/pull/283.
Signed-off-by: Reinhard Nägele [email protected]