-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No chart changes detected #108
Comments
I took a look at your repo and cloned that and run locally the does that still an issue? otherwise lets close this issue, thanks! |
I can verify that this affects me too. Locally:
But, initial PR where I try to use this action doesn't detect any changes. And no checking is done. IMHO, it's not very obvious what I'm doing wrong. And it seems by this, I'm not the only that have problems. |
@MindTooth made a comment in your PR, that change should work, i've tested in a fork and works for me |
@SapiensAnatis i dont see the job in the repo to reproduce the issue |
I saw. Thank you! 🙏🏻 Any reason why I need
|
you also can set |
@SapiensAnatis is right; changes are not being detected.
Maybe detected but although I replace "true" operators with "false", the steps don't work:
|
I added --config .github/ct.yaml, I think it works now. |
It seems like this is being caused by This feels like an anti-pattern, since |
Fixes helm#108 Signed-off-by: Zane Dufour <[email protected]>
Hey, I'm probably messing something up here, but every run of the action on my chart repo is saying that nothing has changed when it has.
Take for instance this run:
https://github.com/SapiensAnatis/helm-charts/actions/runs/4033008969
which was triggered by this commit:
SapiensAnatis/helm-charts@4728958
It says that nothing has changed when I've clearly updated one of the templates. Additionally, I think my directory structure is sound, with
Feel free to look at the repo itself but summarily the chart depends on two bitnami charts (redis and postgresql) and has the following
ct.yaml
When I run the same command that the action is running,
ct list-changed --target-branch master --config ct.yaml --remote=origin
after making a change, I see the chart in the list of changes so not sure what's going onThe text was updated successfully, but these errors were encountered: