Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak ruby version and exercise assignments #3

Merged
merged 6 commits into from
Oct 21, 2021
Merged

Tweak ruby version and exercise assignments #3

merged 6 commits into from
Oct 21, 2021

Conversation

shipstar
Copy link
Contributor

2 things came up in my interview today that seemed worth a small improvement:

  1. Bump Ruby version from 2.7.2 to 2.7.4 to prevent build issues on M1 Macs
  2. Add a data column to exercise_assignments to make it more obvious that exercise_assignments represents each completed instance

hjhart
hjhart approved these changes Oct 21, 2021
View reviewed changes
app/models/exercise_assignment.rb
@@ -4,6 +4,7 @@
#
# id :bigint not null, primary key
# completed_at :datetime
# data :jsonb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I've had to explain this a few times so this settles that bit. :)

@shipstar shipstar merged commit 72b4051 into main Oct 21, 2021
@arich arich deleted the tweak-ruby-version-and-exercise-assignments branch January 7, 2022 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjhart hjhart hjhart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shipstar @hjhart