Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ios detection #7

Merged
merged 4 commits into from
Feb 27, 2022
Merged

add ios detection #7

merged 4 commits into from
Feb 27, 2022

Conversation

webdev03
Copy link
Contributor

Not tested!

@hello-smile6
Copy link
Owner

Doesn't seem to work, can you test with xcode or something?

@webdev03
Copy link
Contributor Author

OK

@webdev03
Copy link
Contributor Author

I tested on my iPhone it works even without da8190b

@hello-smile6
Copy link
Owner

I tested on my iPhone it works even without da8190b

Okay. If you detect the string "iPad", it should detect iPads. It looked like it didn't have it yet.

@hello-smile6
Copy link
Owner

Was just using device emulation in devtools to test, btw

@hello-smile6
Copy link
Owner

Looks good, maybe we should alias Neofetch.osList.apple to Neofetch.osList.macos...

@webdev03
Copy link
Contributor Author

I'm going to revamp the osList system after this gets merged.

@hello-smile6
Copy link
Owner

I'm going to revamp the osList system after this gets merged.

Sounds good

@hello-smile6 hello-smile6 merged commit ed310bd into hello-smile6:main Feb 27, 2022
@webdev03 webdev03 deleted the ios branch February 27, 2022 03:21
@hello-smile6
Copy link
Owner

@webdev03 Why 5500? Why not a port in the first 1024?

@webdev03
Copy link
Contributor Author

??

@hello-smile6
Copy link
Owner

??

Looking at the analytics data, counter.dev shows .local and local IP addresses for some reason. I'm going to open an issue.

@hello-smile6
Copy link
Owner

@hello-smile6
Copy link
Owner

??

Just wanted you to know that it showed that, because it'd be wrong to not tell you.

@hello-smile6
Copy link
Owner

I'll add something that'll check for local domains and abort if it finds any.

@hello-smile6
Copy link
Owner

@webdev03 942b7ed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants