fix(deprecation): disuse deprecated React functional component defaultProps feature#452
Closed
klarstrup wants to merge 3 commits intohello-pangea:mainfrom
Closed
fix(deprecation): disuse deprecated React functional component defaultProps feature#452klarstrup wants to merge 3 commits intohello-pangea:mainfrom
klarstrup wants to merge 3 commits intohello-pangea:mainfrom
Conversation
In the next major React version, `defaultProps` will only be supported on class components. `react-redux`'s `connect` returns a functional component which will not support this in that future. fixes hello-pangea#450
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I managed to fix this by using |
|
Hello, any update on this? |
|
Any update about merging it ? |
Collaborator
|
We made the required change in this PR and it will be part of the next release! 😊 Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the next major React version,
defaultPropswill only be supported on class components.react-redux'sconnectreturns a functional component which will not support this in that future.see https://github.com/reactjs/rfcs/blob/createlement-rfc/text/0000-create-element-changes.md and facebook/react#16210
fixes #450