Add game's first anniversary items (B-22 Model Citizen, Eye of Freedom) #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas Gracioso <[email protected]>
|
I believe AH made it very difficult to get the ID's of each item so I ended up using an unused ID like here |
Got it, that makes sense. When I first read the PR , I was wondering how you got these sequential numbers lol |
Signed-off-by: Lucas Gracioso <[email protected]>
dealloc
reviewed
Feb 13, 2025
Comment on lines
2501
to
2502
| } No newline at end of file | ||
| } |
There was a problem hiding this comment.
I added a new line on EOF - check this file on master
There was a problem hiding this comment.
If the file shouldn't have a new blank line at EOF, I can remove it
Comment on lines
1653
to
1654
| } No newline at end of file | ||
| } |
There was a problem hiding this comment.
Same answer as the other comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the items received as part of the game's first anniversary celebration:
Notes
I couldn’t figure out how these IDs are extracted from the game files, so I left them with
@TODO