Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fallback for Current Version Detection" #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rmwb
Copy link
Contributor

@rmwb rmwb commented Apr 4, 2015

Reverts #61
It won't work. The URLs will be broken.

@rmwb
Copy link
Contributor Author

rmwb commented Apr 4, 2015

Also, downloading an obsolete version could be bad for opsec... I think it would be better for it to fail...

@hellais
Copy link
Owner

hellais commented Apr 4, 2015

Then instead of reverting the previous commit, you should just point the URL to /obsolete/$VERSION

@rmwb
Copy link
Contributor Author

rmwb commented Apr 4, 2015

I don't think we should encourage anyone to use the obsolete versions, they could contain exploitable security flaws.

@hellais
Copy link
Owner

hellais commented Apr 5, 2015

@rmwb I guess that is fair. I don't have a strong opinion for either. @pzp1997 what do you think?

@pzp1997
Copy link
Contributor

pzp1997 commented Apr 6, 2015

I guess we shouldn't encourage obsolete versions for the reasons @rmwb mentioned. But at the same time, we should not have the script break entirely if the filename is changed; that just seems very flimsy. Why don't we prompt the user asking them if they would like to use the older version (with an explanation of the ramifications of doing such) and use the /obsolete/$TAILS VERSION url?

@hellais
Copy link
Owner

hellais commented Apr 6, 2015

Yes prompting the user seems like a good middle ground. @rmwb seems reasonable?

@rmwb
Copy link
Contributor Author

rmwb commented Apr 7, 2015

I really baulk at the potential security implications of installing an obsolete version.
I can see why you would want to be user friendly and give options, but I think security should trump user satisfaction in the case of this particular application and I would still prefer for it to fail gracefully, perhaps with an explanatory note and a suggestion to log the issue on github.

@rmwb
Copy link
Contributor Author

rmwb commented Apr 8, 2015

Regardless of how you plan to implement a fallback URL or not, this particular commit (#61) is poorly coded, will not work as intended and should really be reverted.

@hellais
Copy link
Owner

hellais commented Apr 8, 2015

@rmwb I don't see how you can claim that 2 lines of code are poorly coded.

If we need to be honest this whole script is poorly coded and it's mainly my fault :P.

One day it will all be refactored to be as shiny and perfect as diecut diamond, but that day is not today. 💎

Speaking of the future, this repository will hopefully one day disappear. I have been speaking to Intrigeri (one of the TAILS developers) about merging this effort into something officially supported by TAILS.

From the looks of their latest documentation, they now make images that can just be dd'ied directly onto the drive: https://tails.boum.org/doc/first_steps/installation/manual/mac/index.en.html.

I therefore ask myself does this repository still make sense to exist?
This is probably a topic best discussed in an ad-hoc ticket.

@pzp1997
Copy link
Contributor

pzp1997 commented Apr 8, 2015

Fine let's just let it fail gracefully then. At least this way someone will report that the script is broken on GitHub, so that it can be fixed. @rmwb, would you like to write the explanatory error message?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants