build(deps): bump the npm_and_yarn group across 1 directory with 2 updates - #9
Closed
dependabot[bot] wants to merge 1 commit into
Closed
Conversation
…dates Bumps the npm_and_yarn group with 2 updates in the /script/danger directory: [jws](https://github.com/brianloveswords/node-jws) and [qs](https://github.com/ljharb/qs). Updates `jws` from 3.2.2 to 3.2.3 - [Release notes](https://github.com/brianloveswords/node-jws/releases) - [Changelog](https://github.com/auth0/node-jws/blob/master/CHANGELOG.md) - [Commits](auth0/node-jws@v3.2.2...v3.2.3) Updates `qs` from 6.14.0 to 6.15.0 - [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md) - [Commits](ljharb/qs@v6.14.0...v6.15.0) --- updated-dependencies: - dependency-name: jws dependency-version: 3.2.3 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: qs dependency-version: 6.15.0 dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
lukemarsden
added a commit
that referenced
this pull request
Apr 14, 2026
…topped Three fixes for the systematic n-1 response shift where each message gets the response for the previous message: 1. EntryUpdated uses turn-scoped request_id with prev_turn fallback: Claude Code delivers background events (tool completions, text flushes) asynchronously via session_notification after a turn ends. EntryUpdated now checks whether the entry belongs to the current turn (>= turn_start) or a previous one, and tags it with the correct turn's request_id. Previously it read the global THREAD_REQUEST_MAP which could already point to the next turn. 2. NewEntry updates turn_request_id only at turn boundaries: turn_request_id is now only updated from the global map when current == last_completed (i.e. a new turn is starting). The old value is rotated into prev_turn_request_id for use by late EntryUpdated events from the previous turn. 3. Guard normal-completion Stopped against duplicate emission: When cancel() races with natural turn completion, both paths could emit Stopped. The duplicate triggers the stale-detection fallback which reads the global map (now pointing to the next turn's request_id), sending a premature message_completed that shifts all subsequent responses by one. Added stopped_emitted_for_task check to the normal completion path, matching the existing guard on the cancelled path. Documented as Critical Fix #9 in portingguide.md. E2E tests pass for both zed-agent and claude (all 10 phases). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
3 tasks
Author
|
This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests. To ignore these dependencies, configure ignore rules in dependabot.yml |
dependabot
Bot
deleted the
dependabot/npm_and_yarn/script/danger/npm_and_yarn-76d848a5cd
branch
April 14, 2026 22:15
This was referenced Jun 12, 2026
lukemarsden
added a commit
that referenced
this pull request
Jul 30, 2026
Root cause of the intermittent E2E Phase 17 failure "interrupt message never delivered", found by running the suite repeatedly. A chat_message with interrupt=true fired TWO independent channels for what is semantically one operation: request_cancel_thread() to the dedicated cancel task, and request_thread_creation() to the creation task. Those tasks are separate spawns with no ordering guarantee, so the send can begin before the cancel is processed -- and the cancel then kills the NEW turn instead of the old one. Observed in a failing run (claude round, thread 5c80128a): 07:18:06 turn_cancelled req=int_...6apt (X) <- correct 07:18:06 message_completed req=int_...6apt usage=null 07:18:06 message_completed req=int_...6ejk (Y) usage=null <- Y just created 07:18:06 "Ignoring stale request_id rebind (mapping previously consumed by completion)" 07:19:06 Phase 17: FAIL -- interrupt message never delivered Y was created and completed in the same second with usage=null: its turn never ran. Every healthy completion on that thread carries real usage. Y's real completion was then rejected as a stale rebind, so the interaction never left the waiting state -- the same off-by-one shape Critical Fix #9 addresses, reached by a different route. The interrupt is now carried on ThreadCreationRequest and the cancel is performed inline by the creation task immediately before the send, so the two steps cannot be reordered. The dedicated cancel task is retained for standalone cancel_current_turn, which is what it exists for: cancelling while the creation loop is blocked awaiting a previous turn. cargo test -p external_websocket_sync: 56 passed.
lukemarsden
added a commit
that referenced
this pull request
Jul 30, 2026
…r turn Root cause of the intermittent E2E Phase 17 failure "interrupt message never delivered", found by running the suite repeatedly (~50% failure rate). An interrupt dispatches its cancel out-of-band, to a dedicated task, so it can fire while the sequential creation loop is blocked awaiting the very turn being interrupted. That is necessary -- but it also means the cancel races that loop. If the old turn finishes on its own just as the interrupt arrives, the creation loop starts the NEW turn and the in-flight cancel lands on that instead. Observed in a failing run (claude round, thread 5c80128a): 07:18:06 turn_cancelled req=int_...6apt (X) <- intended 07:18:06 message_completed req=int_...6apt usage=null 07:18:06 message_completed req=int_...6ejk (Y) usage=null <- Y just created 07:18:06 "Ignoring stale request_id rebind (mapping previously consumed by completion)" 07:19:06 Phase 17: FAIL -- interrupt message never delivered Y was created and completed in the same second with usage=null: its turn never ran. Every healthy completion on that thread carries real token usage. Y's real completion was then rejected as a stale rebind, so the interaction never left the waiting state -- the same off-by-one shape Critical Fix #9 addresses, reached by a different route. In production this is a user pressing stop and retyping while a turn streams. The cancel now names the turn it intends to kill: request_cancel_thread() takes an expected_request_id, and the cancel task drops the request as stale if the thread has since moved on. An untargeted cancel (explicit user stop) still cancels whatever is running, by passing None. Rejected alternative: performing the cancel inline in the creation loop. That orders cancel-before-send trivially, but the loop awaits each turn to completion, so an interrupt queued behind a running turn could never cancel it -- trading a race for a deadlock. The dedicated cancel task exists precisely to avoid that, so the fix keeps it and makes it precise instead. cargo test -p external_websocket_sync: 56 passed. cargo check -p zed --features external_websocket_sync: clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the npm_and_yarn group with 2 updates in the /script/danger directory: jws and qs.
Updates
jwsfrom 3.2.2 to 3.2.3Release notes
Sourced from jws's releases.
Changelog
Sourced from jws's changelog.
Commits
4f6e73fMerge commit from forkbd0fea5version 3.2.37c3b4b4Enhance tests for HMAC streaming sign and verifya9b8ed9Improve secretOrKey initialization in VerifyStream6707fdeImprove secret handling in SignStreamMaintainer changes
This version was pushed to npm by julien.wollscheid, a new releaser for jws since your current version.
Updates
qsfrom 6.14.0 to 6.15.0Changelog
Sourced from qs's changelog.
Commits
d9b4c66v6.15.0cb41a54[New]parse: addstrictMergeoption to wrap object/primitive conflicts in...88e1563[Fix]duplicatesoption should not apply to bracket notation keys9d441d2Merge backport release tags v6.0.6–v6.13.3 into main85cc8cav6.12.5ffc12aav6.11.40506b11[actions] update reusable workflows6a37faf[actions] update reusable workflows8e8df5a[Fix] fix regressions from robustness refactord60bab3v6.10.7Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditionsYou can disable automated security fix PRs for this repo from the Security Alerts page.