Add response entries isolation validation to E2E test - #31
Merged
Conversation
Validates that follow-up interactions in the same session don't contain message_ids from previous interactions — detects the bug where Zed's flush_streaming_throttle resends ALL thread entries and the Helix accumulator re-accumulates old ones. Checks all sessions with multiple completed interactions, groups by session, and verifies no message_id appears in more than one interaction. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validateStore()in the Zed WebSocket sync E2E testmessage_ids from previous interactionsflush_streaming_throttleresends ALL thread entries and the Helix accumulator re-accumulates old ones (fixed in Fix response_entries accumulating across interactions in same ACP thread helix#2116)Test plan
zed-agent(22 interactions, 6 sessions, 0 isolation violations)zed-agentandclaudeagentsHelix PR: helixml/helix#2116 (bump
sandbox-versions.txtincluded there)Merge order: Merge this Zed PR first, then the Helix PR.
🤖 Generated with Claude Code