fix(sandbox-versions): repoint ZED_COMMIT to merge commit (fetch-by-SHA fix) - #2562
Merged
Merged
Conversation
…HA fix) Build 1943 stage 5 (build-sandbox-amd64) failed at clone-dependencies: fatal: remote error: upload-pack: not our ref e4c36d837cb71ee10a26d8617be770fa75b9c25d GitHub's upload-pack only allows fetching refs (HEAD, branches, tags) or commits explicitly reachable from one via uploadpack.allowReachableSHA1InWant. By default it rejects fetch-by-SHA for arbitrary internal commits. The previous bump in #2559 pinned the branch commit (the last commit on the merged feature branch) rather than the merge commit on zed/main, so clone-dependencies' `git fetch --depth 1 <sha>` was rejected. Repoint to the merge commit (helixml/zed@ecdc2ea67d, "Merge pull request #60") which is reachable from origin/main and therefore fetchable. Pattern to follow for future ZED_COMMIT bumps: use the merge commit on zed/main (`git rev-parse origin/main` after pulling), not the feature branch tip. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Build 1943 stage 5 (build-sandbox-amd64) failed at clone-dependencies:
```
fatal: remote error: upload-pack: not our ref e4c36d837cb71ee10a26d8617be770fa75b9c25d
```
GitHub's `upload-pack` only serves refs (HEAD, branches, tags) or commits explicitly reachable from one via `uploadpack.allowReachableSHA1InWant`. By default it rejects fetch-by-SHA for arbitrary internal commits. The previous bump in #2559 pinned the branch commit (the last commit on the merged feature branch) rather than the merge commit on `zed/main`, so `clone-dependencies`' `git fetch --depth 1 ` was rejected.
Fix
Repoint `ZED_COMMIT` to `ecdc2ea67d5f731c3babc3d1f17bf10b2eb1825d` — the merge commit of helixml/zed#60, reachable from `zed/main`.
Pattern for future ZED_COMMIT bumps
Use the merge commit on `zed/main` (`git rev-parse origin/main` after pulling), not the feature branch tip. Worth a future tweak to `scripts/` or the CI step to validate this automatically, but that's out of scope here.
Test plan
🤖 Generated with Claude Code