ci(zed-e2e): bump ZED_COMMIT for Phase 16 counter fix - #2427
Merged
Conversation
Picks up helixml/zed test(e2e) fix that excludes Phase 10's own ProcessSyncEvent-injected user_created_thread from the Phase 16 deferred-emit counter. Both rounds (zed-agent + claude) currently fail on main because the assertion was counting the injection as a "spontaneous" event — the underlying Zed deferred-emit fix from PR #56 is in place and working. Verified locally with E2E_AGENTS="zed-agent,claude" ./run_docker_e2e.sh — both rounds PASSED, Phase 16 reports 0 spontaneous events. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ZED_COMMITinsandbox-versions.txtto pick up test(e2e): exclude Phase 10's own injection from Phase 16 counter zed#57.deferred-emitregression assertion in the WebSocket sync E2E test, which is currently failing on everymainbuild (e.g. https://drone.lukemarsden.net/helixml/helix/1424).Root cause
Phase 10 of the E2E test injects a synthetic
user_created_threadviasrv.ProcessSyncEvent(...). That call goes through the sameprocessExternalAgentSyncMessagepath as real WebSocket-delivered events, so it fires the test driver'ssyncEventCallback→spontaneousUserCreatedThreadCount++. The Phase 16 assertion at the end of the round then sees one event and fails with:Both rounds (
zed-agentandclaude) fail with exactly 1 phantom event, and theacp_thread_idmatches the synthetic format (user-thread-{agent}-{nanos}) generated only by the test driver inrunPhase10. The underlying Zed deferred-emit fix from helixml/zed#56 is in place and working — this is purely a test-side bookkeeping bug.Fix
In the Zed PR: filter out Phase 10's known synthetic
acp_thread_idfrom the Phase 16 counter by exact match. Zed only ever emits ACP UUIDs, neveruser-thread-*, so the exclusion cannot mask a real regression — any otheruser_created_threadevent still fails Phase 16.Test plan
cd ~/pm/zed/crates/external_websocket_sync/e2e-test && E2E_AGENTS="zed-agent,claude" ./run_docker_e2e.sh— both rounds PASSED, Phase 16 reports0 spontaneous user_created_thread events — Fix 1a deferred-emit working as expected.🤖 Generated with Claude Code