Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jump label color to dracula themes #9973

Merged
merged 1 commit into from
Mar 23, 2024
Merged

Add jump label color to dracula themes #9973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions runtime/themes/dracula.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@
"ui.virtual.inlay-hint" = { fg = "cyan" }
"ui.virtual.inlay-hint.parameter" = { fg = "cyan", modifiers = ["italic", "dim"] }
"ui.virtual.inlay-hint.type" = { fg = "cyan", modifiers = ["italic", "dim"] }
"ui.virtual.jump-label" = { fg = "pink", modifiers = ["bold"] }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried out this theme, I suspect this is a "me" problem but wanted to check-in

Should fg be updating the actual text characters colour?
Using this instead of my custom one and it just seems to flip the characters without additional styles? (I'm using iTerm2 on MacOS, and I may not have that set up properly)

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it's supposed to highlight the 2 first characters in pink. Example:
image

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yo-main Ah okay yeah I can see how that fits the Dracula style well now! Thanks for the screenshot, I'll keep poking around my Terminal's settings then.

I'm using reversed in my custom theme, which is pretty in-your-face but makes it clear something has happened (especially with how often I've been pairing with other devs recently)
image

"ui.virtual.ruler" = { bg = "black" }
"ui.virtual.whitespace" = { fg = "whitespace" }
"ui.virtual.wrap" = { fg = "current_line" }
Expand Down
1 change: 1 addition & 0 deletions runtime/themes/dracula_at_night.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
"ui.text" = { fg = "foreground" }
"ui.text.focus" = { fg = "cyan" }
"ui.window" = { fg = "foreground" }
"ui.virtual.jump-label" = { fg = "pink", modifiers = ["bold"] }
"ui.virtual.ruler" = { bg = "background_dark" }

"error" = { fg = "red" }
Expand Down
Loading