Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define bufferline colors for gruvbox #9960

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

cartwatson
Copy link
Contributor

Gruvbox theme doesn't take advantage of specific bufferline colors and just uses defaults

Colors were chosen for the following reasons:

  • bufferline
    • fg - default text color
    • bg - slightly darker than statusline, enough contrast to see tabs
  • bufferline.active
    • fg - contrast, hard and soft contrast will change this
    • bg - arbitrary, just looked right of the available colors in the palette
  • bufferline.background
    • bg - match statusline

@cartwatson cartwatson changed the title fix: undefined bufferline colors undefined bufferline colors for gruvbox Mar 21, 2024
@the-mikedavis the-mikedavis changed the title undefined bufferline colors for gruvbox define bufferline colors for gruvbox Mar 21, 2024
@the-mikedavis the-mikedavis added A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer. labels Mar 21, 2024
@pascalkuthe pascalkuthe merged commit be307a4 into helix-editor:master Mar 21, 2024
6 checks passed
Desdaemon pushed a commit to Desdaemon/helix that referenced this pull request Mar 26, 2024
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 20, 2024
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants