Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rasmus.toml #9939

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Update rasmus.toml #9939

merged 2 commits into from
Mar 21, 2024

Conversation

jordanreger
Copy link

Remove "ui.virtual" setting as it selects seemingly random characters to highlight.

image

To demonstrate what I'm talking about, I changed "gray03" (which is what "ui.virtual" is set to) to orange and everything else to gray.

Also, as per the docs, it seems as if this isn't a real field.

image It is fixed in the above picture.

Remove "ui.virtual" setting as it selects seemingly random characters to highlight.
@the-mikedavis
Copy link
Member

That's the ruler - it should most likely be a background color instead:

"ui.virtual.ruler" = { bg = "gray03" }

@jordanreger
Copy link
Author

This should be changed to ui.virtual.ruler then? This theme doesn't have one otherwise

@the-mikedavis
Copy link
Member

ui.virtual can stay but ui.virtual.ruler should be added. The theme keys fall back when not defined so looking up ui.virtual.ruler will return ui.virtual's theming when ui.virtual.ruler isn't defined

@jordanreger
Copy link
Author

Added ui.virtual.ruler and added back ui.virtual

@the-mikedavis the-mikedavis added A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer. labels Mar 20, 2024
@archseer archseer merged commit 5ba36fe into helix-editor:master Mar 21, 2024
6 checks passed
@jordanreger jordanreger deleted the patch-1 branch March 21, 2024 03:36
Desdaemon pushed a commit to Desdaemon/helix that referenced this pull request Mar 26, 2024
* Update rasmus.toml

Remove "ui.virtual" setting as it selects seemingly random characters to highlight.

* Add ui.virtual.ruler
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
* Update rasmus.toml

Remove "ui.virtual" setting as it selects seemingly random characters to highlight.

* Add ui.virtual.ruler
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
* Update rasmus.toml

Remove "ui.virtual" setting as it selects seemingly random characters to highlight.

* Add ui.virtual.ruler
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
* Update rasmus.toml

Remove "ui.virtual" setting as it selects seemingly random characters to highlight.

* Add ui.virtual.ruler
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 20, 2024
* Update rasmus.toml

Remove "ui.virtual" setting as it selects seemingly random characters to highlight.

* Add ui.virtual.ruler
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
* Update rasmus.toml

Remove "ui.virtual" setting as it selects seemingly random characters to highlight.

* Add ui.virtual.ruler
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
* Update rasmus.toml

Remove "ui.virtual" setting as it selects seemingly random characters to highlight.

* Add ui.virtual.ruler
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
* Update rasmus.toml

Remove "ui.virtual" setting as it selects seemingly random characters to highlight.

* Add ui.virtual.ruler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants