Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add register completion for typed commands #9936

Merged
merged 1 commit into from
Mar 19, 2024
Merged

add register completion for typed commands #9936

merged 1 commit into from
Mar 19, 2024

Conversation

kirawi
Copy link
Member

@kirawi kirawi commented Mar 19, 2024

This also adjusts yank_diagnostic to fail early if the register argument is invalid

@kirawi kirawi added the A-command Area: Commands label Mar 19, 2024
@the-mikedavis the-mikedavis added the S-waiting-on-review Status: Awaiting review from a maintainer. label Mar 19, 2024
pascalkuthe
pascalkuthe approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@pascalkuthe pascalkuthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a nice QOL change. I do wonder if we want to accept registers in more commands (for example yank-join as a second parameter)

@pascalkuthe pascalkuthe merged commit d9de809 into helix-editor:master Mar 19, 2024
6 checks passed
@kirawi kirawi deleted the register branch March 19, 2024 16:34
Desdaemon pushed a commit to Desdaemon/helix that referenced this pull request Mar 26, 2024
@kirawi @Desdaemon
add register completion (helix-editor#9936)
612e282
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
@kirawi @postsolar
add register completion (helix-editor#9936)
62eb9e0
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
@kirawi @postsolar
add register completion (helix-editor#9936)
c479f83
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
@kirawi @postsolar
add register completion (helix-editor#9936)
acd6f86
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 20, 2024
@kirawi @postsolar
add register completion (helix-editor#9936)
9bf6da3
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
@kirawi @mtoohey31
add register completion (helix-editor#9936)
eb2e270
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
@kirawi @Vulpesx
add register completion (helix-editor#9936)
5e70b94
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
@kirawi
add register completion (helix-editor#9936)
c538157
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

@pascalkuthe pascalkuthe pascalkuthe approved these changes

Assignees
No one assigned
Labels
A-command Area: Commands S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kirawi @the-mikedavis @pascalkuthe