Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tcl highlighting #9837

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Add tcl highlighting #9837

merged 2 commits into from
Apr 4, 2024

Conversation

Eloitor
Copy link
Contributor

@Eloitor Eloitor commented Mar 8, 2024

No description provided.

@Eloitor
Copy link
Contributor Author

Eloitor commented Mar 8, 2024

Is it possible to detect the following line in the second line of a script?

# -*-Mode: TCL;-*-

Some files created with Emacs have it...

@the-mikedavis
Copy link
Member

Not currently, that's roughly covered by #729

@the-mikedavis the-mikedavis added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. A-language-support Area: Support for programming/text languages labels Mar 8, 2024
the-mikedavis
the-mikedavis reviewed Mar 8, 2024
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep the new queries look good. I just have a few minor comments

runtime/queries/tcl/highlights.scm Outdated Show resolved Hide resolved
runtime/queries/tcl/indents.scm Outdated Show resolved Hide resolved
the-mikedavis
the-mikedavis previously approved these changes Mar 8, 2024
View reviewed changes
@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 8, 2024
pascalkuthe
pascalkuthe reviewed Mar 17, 2024
View reviewed changes
Copy link
Member

@pascalkuthe pascalkuthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a rebase and still has some problems with the queries

runtime/queries/tcl/highlights.scm Outdated Show resolved Hide resolved
@pascalkuthe pascalkuthe added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from a maintainer. labels Mar 17, 2024
@Eloitor
Copy link
Contributor Author

Eloitor commented Mar 18, 2024

Thanks, I did the rebase. I don't know how to solve the problems...

@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 18, 2024
@pascalkuthe pascalkuthe merged commit 88f2931 into helix-editor:master Apr 4, 2024
6 checks passed
@pascalkuthe pascalkuthe mentioned this pull request Apr 4, 2024
Closed
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
@Eloitor @the-mikedavis @postsolar
Add tcl highlighting (helix-editor#9837)
b3c8b1c 
Co-authored-by: Michael Davis <[email protected]>
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
@Eloitor @the-mikedavis @postsolar
Add tcl highlighting (helix-editor#9837)
1f2d16e 
Co-authored-by: Michael Davis <[email protected]>
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
@Eloitor @the-mikedavis @postsolar
Add tcl highlighting (helix-editor#9837)
d1db74f 
Co-authored-by: Michael Davis <[email protected]>
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
@Eloitor @the-mikedavis @postsolar
Add tcl highlighting (helix-editor#9837)
f0868cb 
Co-authored-by: Michael Davis <[email protected]>
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 20, 2024
@Eloitor @the-mikedavis @postsolar
Add tcl highlighting (helix-editor#9837)
81e5980 
Co-authored-by: Michael Davis <[email protected]>
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
@Eloitor @the-mikedavis @mtoohey31
Add tcl highlighting (helix-editor#9837)
32d3312 
Co-authored-by: Michael Davis <[email protected]>
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
@Eloitor @the-mikedavis @Vulpesx
Add tcl highlighting (helix-editor#9837)
5379ccf 
Co-authored-by: Michael Davis <[email protected]>
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
@Eloitor @the-mikedavis
Add tcl highlighting (helix-editor#9837)
278e602 
Co-authored-by: Michael Davis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

@pascalkuthe pascalkuthe pascalkuthe approved these changes

Assignees
No one assigned
Labels
A-language-support Area: Support for programming/text languages S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Eloitor @the-mikedavis @pascalkuthe