Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent shell_keep_pipe from stopping on nonzero exit status code #9817

Merged
merged 1 commit into from
Mar 19, 2024

Commits on Mar 5, 2024

  1. Prevent shell_keep_pipe from stopping on nonzero exit status code

    The `shell_impl` and `shell_impl_async` functions no longer return
    `success` because it was always `true`. If the command didn't succeed
    both functions would return an `Err`.
    
    This was also the reason, why `shell_keep_pipe` didn't work. It relied
    upon the value of `success` and aborted in case of an `Err`.
    It now removes any selection for which `shell_impl` returns `Err`.
    
    If the command always fails, the selections are preserved and an error
    message is displayed in the status bar.
    sirius94 committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    2301662 View commit details
    Browse the repository at this point in the history