Fix selected text background in toykonight #9789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the fix, the color that the original (Neovim) tokyonight uses for Neovim's visual mode was used in Helix for highlighting the selected item in the picker. But for the highlighting of selected _text_ in Helix (corresponding to Neovim's visual mode), a much darker background was used. This made it very hard to pick out selected text, in particular in suboptimal lighting conditions. I swapped the two colors, so that text selection now looks like in Neovim, while selected items in the picker are highlighted a bit less strongly. (But still easy to see because the whole line is highlighted.)
the-mikedavis
approved these changes
Mar 3, 2024
the-mikedavis
added
A-theme
pascalkuthe
approved these changes
Mar 17, 2024
Desdaemon
pushed a commit
to Desdaemon/helix
that referenced
this pull request
Mar 26, 2024
Before the fix, the color that the original (Neovim) tokyonight uses for Neovim's visual mode was used in Helix for highlighting the selected item in the picker. But for the highlighting of selected _text_ in Helix (corresponding to Neovim's visual mode), a much darker background was used. This made it very hard to pick out selected text, in particular in suboptimal lighting conditions. I swapped the two colors, so that text selection now looks like in Neovim, while selected items in the picker are highlighted a bit less strongly. (But still easy to see because the whole line is highlighted.)
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
Before the fix, the color that the original (Neovim) tokyonight uses for Neovim's visual mode was used in Helix for highlighting the selected item in the picker. But for the highlighting of selected _text_ in Helix (corresponding to Neovim's visual mode), a much darker background was used. This made it very hard to pick out selected text, in particular in suboptimal lighting conditions. I swapped the two colors, so that text selection now looks like in Neovim, while selected items in the picker are highlighted a bit less strongly. (But still easy to see because the whole line is highlighted.)
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
Before the fix, the color that the original (Neovim) tokyonight uses for Neovim's visual mode was used in Helix for highlighting the selected item in the picker. But for the highlighting of selected _text_ in Helix (corresponding to Neovim's visual mode), a much darker background was used. This made it very hard to pick out selected text, in particular in suboptimal lighting conditions. I swapped the two colors, so that text selection now looks like in Neovim, while selected items in the picker are highlighted a bit less strongly. (But still easy to see because the whole line is highlighted.)
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
Before the fix, the color that the original (Neovim) tokyonight uses for Neovim's visual mode was used in Helix for highlighting the selected item in the picker. But for the highlighting of selected _text_ in Helix (corresponding to Neovim's visual mode), a much darker background was used. This made it very hard to pick out selected text, in particular in suboptimal lighting conditions. I swapped the two colors, so that text selection now looks like in Neovim, while selected items in the picker are highlighted a bit less strongly. (But still easy to see because the whole line is highlighted.)
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 20, 2024
Before the fix, the color that the original (Neovim) tokyonight uses for Neovim's visual mode was used in Helix for highlighting the selected item in the picker. But for the highlighting of selected _text_ in Helix (corresponding to Neovim's visual mode), a much darker background was used. This made it very hard to pick out selected text, in particular in suboptimal lighting conditions. I swapped the two colors, so that text selection now looks like in Neovim, while selected items in the picker are highlighted a bit less strongly. (But still easy to see because the whole line is highlighted.)
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
Before the fix, the color that the original (Neovim) tokyonight uses for Neovim's visual mode was used in Helix for highlighting the selected item in the picker. But for the highlighting of selected _text_ in Helix (corresponding to Neovim's visual mode), a much darker background was used. This made it very hard to pick out selected text, in particular in suboptimal lighting conditions. I swapped the two colors, so that text selection now looks like in Neovim, while selected items in the picker are highlighted a bit less strongly. (But still easy to see because the whole line is highlighted.)
Vulpesx
pushed a commit
to Vulpesx/helix
that referenced
this pull request
Jun 7, 2024
Before the fix, the color that the original (Neovim) tokyonight uses for Neovim's visual mode was used in Helix for highlighting the selected item in the picker. But for the highlighting of selected _text_ in Helix (corresponding to Neovim's visual mode), a much darker background was used. This made it very hard to pick out selected text, in particular in suboptimal lighting conditions. I swapped the two colors, so that text selection now looks like in Neovim, while selected items in the picker are highlighted a bit less strongly. (But still easy to see because the whole line is highlighted.)
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Before the fix, the color that the original (Neovim) tokyonight uses for Neovim's visual mode was used in Helix for highlighting the selected item in the picker. But for the highlighting of selected _text_ in Helix (corresponding to Neovim's visual mode), a much darker background was used. This made it very hard to pick out selected text, in particular in suboptimal lighting conditions. I swapped the two colors, so that text selection now looks like in Neovim, while selected items in the picker are highlighted a bit less strongly. (But still easy to see because the whole line is highlighted.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the fix, the color that the original (Neovim) tokyonight uses for Neovim's visual mode was used in Helix for highlighting the selected item in the picker. But for the highlighting of selected text in Helix (corresponding to Neovim's visual mode), a much darker background was used. This made it very hard to pick out selected text, in particular in suboptimal lighting conditions.
I swapped the two colors, so that text selection now looks like in Neovim, while selected items in the picker are highlighted a bit less strongly. (But still easy to see because the whole line is highlighted.)