Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add markdown-oxide language server #9758

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

Feel-ix-343
Copy link
Contributor

@Feel-ix-343 Feel-ix-343 commented Feb 29, 2024

I would like to add this language server. How do you all handle this? https://github.com/Feel-ix-343/markdown-oxide

Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If markdown-oxide is specific to obsidian markdown it would probably be best to only add this in the language server wiki: https://github.com/helix-editor/helix/wiki/How-to-install-the-default-language-servers

But if it's generally useful for markdown then this patch looks good. You'll just need to run cargo xtask docgen and commit the changes to fix the docs CI

@the-mikedavis the-mikedavis added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. A-language-support Area: Support for programming/text languages labels Feb 29, 2024
@Feel-ix-343
Copy link
Contributor Author

It is compatible with obsidian and takes influence from it but is primarily an advanced markdown language server.

There are a few people who are migrating to it not from obsidian but from marksman and other non obsidian systems.

I think it is general enough to be built in.

@Feel-ix-343 Feel-ix-343 marked this pull request as ready for review February 29, 2024 22:57
@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 29, 2024
@the-mikedavis the-mikedavis merged commit 062fb81 into helix-editor:master Mar 1, 2024
6 checks passed
Desdaemon pushed a commit to Desdaemon/helix that referenced this pull request Mar 4, 2024
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants