Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix split_on_newline #9756

Merged
merged 1 commit into from
Feb 29, 2024
Merged

fix split_on_newline #9756

merged 1 commit into from
Feb 29, 2024

Conversation

pascalkuthe
Copy link
Member

closes #9752
fixes regression introduced in #9422

I forgot the way the ropey lines iterator work (despite having written it) so I didn't properly conciser that the last yielded line will never have a line terminator and used an ill-advised unwrap_or(0). I cleaned up the code a bit in the process

@pascalkuthe pascalkuthe added this to the next milestone Feb 28, 2024
@pascalkuthe pascalkuthe added C-bug Category: This is a bug E-easy Call for participation: Experience needed to fix: Easy / not much S-waiting-on-review Status: Awaiting review from a maintainer. A-command Area: Commands labels Feb 28, 2024
@archseer archseer merged commit 1143f47 into master Feb 29, 2024
6 checks passed
@archseer archseer deleted the select_newline_fix branch February 29, 2024 01:47
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-command Area: Commands C-bug Category: This is a bug E-easy Call for participation: Experience needed to fix: Easy / not much S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

split_selection_on_newlines selects following line too
3 participants