Avoid cloning the whole paragraph content just for rendering #9739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalkuthe
previously approved these changes
Feb 27, 2024
|
Fixed the tests. I couldn't run them locally because of #9710 |
the-mikedavis
approved these changes
Feb 27, 2024
the-mikedavis
added
the
S-waiting-on-review
pascalkuthe
approved these changes
Feb 27, 2024
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
…ditor#9739) * Avoid cloning the whole paragraph content just for rendering * Fix tests
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
…ditor#9739) * Avoid cloning the whole paragraph content just for rendering * Fix tests
Vulpesx
pushed a commit
to Vulpesx/helix
that referenced
this pull request
Jun 7, 2024
…ditor#9739) * Avoid cloning the whole paragraph content just for rendering * Fix tests
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
…ditor#9739) * Avoid cloning the whole paragraph content just for rendering * Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No corresponding issue, just found it odd while reading. Feel free to reject it, but I think that cloning the whole content of a paragraph just to render it can be significant. This is not just one allocation, these are multiple allocations because
Textis a vector of vectors of possibly owned strings.