Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ahash breaking nightly #9666

Closed

Conversation

McPatate
Copy link

When building helix in nightly, I get the following error:

error[E0635]: unknown feature `stdsimd`
  --> /home/mc/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ahash-0.8.6/src/lib.rs:99:42
   |
99 | #![cfg_attr(feature = "stdsimd", feature(stdsimd))]
   |                                          ^^^^^^^

The issue appears to have been fixed in 0.8.7, cf tkaitchuck/aHash#200.

@pascalkuthe
Copy link
Member

We can't update because the msrv is higher than ours

@pascalkuthe
Copy link
Member

pascalkuthe commented Feb 19, 2024

Did you build with --locked we specifically did not upgrade ahash in our lock file yet to work around this

@McPatate
Copy link
Author

McPatate commented Feb 19, 2024

We can't update because the msrv is higher than ours

Ah, I updated to 0.8.8 which in fact did not work, but then when running cargo update -p [email protected] --precise 0.8.7 everything worked and I didn't get a MSRV error & everything compiles (haven't run the tests though).

@McPatate
Copy link
Author

McPatate commented Feb 19, 2024

Tests at root, in helix-event & helix-core all pass with rust 1.70 and my nightly toolchain

@the-mikedavis
Copy link
Member

the-mikedavis commented Feb 19, 2024

Are you using rust 1.70.0? That's what we're locked at: https://github.com/helix-editor/helix/blob/master/rust-toolchain.toml

Also see #9142

@McPatate
Copy link
Author

# rustup show
Default host: x86_64-unknown-linux-gnu
rustup home:  /hidden/.rustup

installed toolchains
--------------------

stable-x86_64-unknown-linux-gnu (default)
nightly-x86_64-unknown-linux-gnu
1.65.0-x86_64-unknown-linux-gnu
1.70.0-x86_64-unknown-linux-gnu

active toolchain
----------------

1.70.0-x86_64-unknown-linux-gnu (overridden by '/hidden/helix/rust-toolchain.toml')
rustc 1.70.0 (90c541806 2023-05-31)

@the-mikedavis
Copy link
Member

Oh right, 0.8.7 only uses Rust 1.72.0 features for aarch64 builds, see #9294

0.8.8 fixes ahash's declared MSRV

@pascalkuthe

This comment was marked as duplicate.

@McPatate
Copy link
Author

for aarch64

The joys of multi platform 😄

Sorry missed that detail!

@McPatate McPatate deleted the fix/ahash_breaking_nightly branch February 19, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants