-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ahash breaking nightly #9666
Conversation
We can't update because the msrv is higher than ours |
Did you build with --locked we specifically did not upgrade ahash in our lock file yet to work around this |
Ah, I updated to |
Tests at root, in |
Are you using rust 1.70.0? That's what we're locked at: https://github.com/helix-editor/helix/blob/master/rust-toolchain.toml Also see #9142 |
|
Oh right, 0.8.7 only uses Rust 1.72.0 features for aarch64 builds, see #9294 0.8.8 fixes ahash's declared MSRV |
This comment was marked as duplicate.
This comment was marked as duplicate.
The joys of multi platform 😄 Sorry missed that detail! |
When building helix in nightly, I get the following error:
The issue appears to have been fixed in
0.8.7
, cf tkaitchuck/aHash#200.