Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): bump tempfile from 3.9.0 to 3.10.0 #9538

Merged
merged 1 commit into from
Feb 12, 2024
Merged

build(deps): bump tempfile from 3.9.0 to 3.10.0 #9538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion helix-loader/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ log = "0.4"
# cloning/compiling tree-sitter grammars
cc = { version = "1" }
threadpool = { version = "1.0" }
tempfile = "3.9.0"
tempfile = "3.10.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The non-dev-dependency usage of tempfile in helix-loader seems odd to me:

helix/helix-loader/src/grammar.rs

Lines 447 to 448 in 5c567f3

// used to delay dropping the temporary object file until after the compilation is complete
let _path_guard;

@pascalkuthe do we need the tempfile dependency to keep that data alive or can we just assign it? I'm not sure what the TempPath::from_path call is accomplishing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TempPath is a drop guard that will ensure the path is deleted when it's dropped (so even if we panic or return early due to an error we don't want to keep object files lying around). You could write something like that yourself but we already depend on tempfile elsewhere (both as dev and non-dev dependency) so it seemed easier to just pull it im resther than recreating that

dunce = "1.0.4"

[target.'cfg(not(target_arch = "wasm32"))'.dependencies]
Expand Down
2 changes: 1 addition & 1 deletion helix-stdx/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ ropey = { version = "1.6.1", default-features = false }
which = "6.0"

[dev-dependencies]
tempfile = "3.9"
tempfile = "3.10"
2 changes: 1 addition & 1 deletion helix-term/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,4 +84,4 @@ helix-loader = { path = "../helix-loader" }
[dev-dependencies]
smallvec = "1.13"
indoc = "2.0.4"
tempfile = "3.9.0"
tempfile = "3.10.0"
2 changes: 1 addition & 1 deletion helix-vcs/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,4 @@ log = "0.4"
git = ["gix"]

[dev-dependencies]
tempfile = "3.9"
tempfile = "3.10"
Loading