Add support for Odin's formatter #9537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The language server does support auto-formatting, however |
|
If you have an external formatter and the language server installed, we currently prefer the formatter even though it's likely less efficient than the language server computing and sending the edits (since we need to shell out and then generate the edits between the old and new text). I think this comes up with other languages though (Zig IIRC) so I'll make a separate issue and let's merge this as-is 👍 (#9543) |
the-mikedavis
approved these changes
Feb 6, 2024
the-mikedavis
added
S-waiting-on-review
cosmikwolf
pushed a commit
to cosmikwolf/helix
that referenced
this pull request
Feb 26, 2024
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
Vulpesx
pushed a commit
to Vulpesx/helix
that referenced
this pull request
Jun 7, 2024
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Odin's language server also comes with a formatter, so it would be nice to make use of it.