Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding two themes using only colors from 16-color terminal themes #9477

Merged
merged 5 commits into from
Feb 4, 2024

Conversation

dgkf
Copy link
Contributor

@dgkf dgkf commented Jan 30, 2024

Adds two themes, using only the 16 color palette used for terminal themes.

image (Tango Light)

This allows for the helix theme to match the terminal theme more consistently for those of us that like to have a helix pane open in a terminal multiplexer.

The theme style choices are meant to look best for palettes that reasonably adhere to the 8-color palette + 8 lighter variants. At least in kitty, many of the themes do not adhere to this style - the "lighter" color is often darker than the base color, or the "white" and "black" colors are swapped. I prioritized accommodating the themes that adhere more closely to the spec, so some of these deviating themes sometimes have quirks.

Here are some screenshots of some themes that adhere to the general ansi palette:

kitty theme (light) term16_dark term16_light
Tango (Tango Light)
Ayu (Ayu Light) image image
Solarized Dark* (Solarized Light) image image
Pencil Dark (Pencil Light) image image

*Used "Higher Contrast" variant because the kitty default Solarized Dark uses grey for all the "light" variants

@the-mikedavis the-mikedavis added A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer. labels Jan 30, 2024
@dgkf dgkf requested a review from ascarter January 31, 2024 17:37
@pascalkuthe pascalkuthe merged commit 5c567f3 into helix-editor:master Feb 4, 2024
6 checks passed
cosmikwolf pushed a commit to cosmikwolf/helix that referenced this pull request Feb 26, 2024
…lix-editor#9477)

* adding 16-color terminal themes

* minor consistency update

* minor consistency update

* rename to be more consistent with other helix theme name conventions

* fixing improper theme inherits name
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
…lix-editor#9477)

* adding 16-color terminal themes

* minor consistency update

* minor consistency update

* rename to be more consistent with other helix theme name conventions

* fixing improper theme inherits name
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
…lix-editor#9477)

* adding 16-color terminal themes

* minor consistency update

* minor consistency update

* rename to be more consistent with other helix theme name conventions

* fixing improper theme inherits name
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
…lix-editor#9477)

* adding 16-color terminal themes

* minor consistency update

* minor consistency update

* rename to be more consistent with other helix theme name conventions

* fixing improper theme inherits name
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
…lix-editor#9477)

* adding 16-color terminal themes

* minor consistency update

* minor consistency update

* rename to be more consistent with other helix theme name conventions

* fixing improper theme inherits name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants