Reverse query precedence ordering #9458
Draft
+786
−466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
added
A-tree-sitter
|
dump question: couldn't we simply write a script that reads all queries and reverses all lines? It would be ugly but at least trivially correct. |
|
It would probably be a little tricky to write so that it handles comments correctly but yeah that would be the most efficient way |
|
There's also files that were copied and weren't properly reversed in the first place |
…cedence order This commit adapts PureScript highlight queries to match upcoming changes in Helix which will make queries matching order go from more to general to more specific, the opposite of previous order.
Update julia parser to latest version, along with: - updating the queries, - pulling changes from `nvim-treesitter`’s queries (as the maintainters of the parser update the queries there), - reversing the queries’ order to be compatible with upstream.
archseer
force-pushed
the
reverse-query-precedence-ordering
branch
from
17bb6b4
to
951b454
Compare
|
I added a progress checklist to the PR description. I'm going through these one by one and comparing them to the nvim-treesitter ordering: in many cases there's nothing to do or the file wasn't correctly reordered in the first place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress: we need to check the other tree-sitter queries (injections, indents, textobjects) and ensure that they also use the latest match. We also need to re-order and check all of the existing highlight queries. For now I've started small and only ported over Erlang's highlights.
Closes #9436
Progress
TODO: also verify locals, indents