-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semantic tokens #9360
base: master
Are you sure you want to change the base?
Semantic tokens #9360
Conversation
My main focus has been trying to workout how to use semantic highlighting to define new local definitions. It took a while since I went through some overly complicated designs before arriving at the one I'm proposing now:
Aside from the above, the actual rendering of semantic highlights would involve a system very similar to inlay hints. |
@the-mikedavis I'm actually not sure that the approach I outlined above is optimal because a I am thinking of storing a vector of |
In the future, I think #1115 can be handled through the same code path as semantic tokens. |
Yeah extra information from the LSP that needs to be mapped through changes should live on the Document. #1115 is more complicated and I don't think it will overlap with this. Knowing all of the definitions in the document (which you could figure out when running injections queries) doesn't help since you also need to run highlights across potentially the entire text in order to determine the |
Based on #8021
TODO
Notes
locals.scm
from the semantic highlighting. I will be taking a look at this soon, but this is something that would also need to be addressed for Feature Request: Support stack-graphs to provide code nav in the absence of LSP, building on tree-sitter #1252 in the future.