Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit a language server if it sends a message with invalid json #9332

Merged
merged 11 commits into from
Jan 17, 2024
Merged

Exit a language server if it sends a message with invalid json #9332

merged 11 commits into from
Jan 17, 2024

Commits on Jan 13, 2024

  1. Keep lsp event listener thread alive when malformed json is encounter… 

    …ed from the lsp server
    @bendennis
    bendennis committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    1ff12a7 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. Update unexpected error flow in recv() to close outstanding requests … 

    …and close the language server
    @bendennis
    bendennis committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    aafbd51 View commit details
    Browse the repository at this point in the history

  2. Log malformed notifications as info instead of error

    @bendennis
    bendennis committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    383fe43 View commit details
    Browse the repository at this point in the history

  3. Make close_language_server a nested function inside recv, similar to … 

    …what's done in send
    @bendennis
    bendennis committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    bef57cd View commit details
    Browse the repository at this point in the history

  4. Update malformed notification log text

    @bendennis
    bendennis committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    e18329c View commit details
    Browse the repository at this point in the history

  5. Clean up new log text a bit

    @bendennis
    bendennis committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    1c14f21 View commit details
    Browse the repository at this point in the history

  6. Initialize recv_buffer closer to where it's used

    @bendennis
    bendennis committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    efdd577 View commit details
    Browse the repository at this point in the history

  7. Use "exit" instead of "close"

    @bendennis
    bendennis committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    68929b2 View commit details
    Browse the repository at this point in the history

  8. Remove whitespace

    @bendennis
    bendennis committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    7366321 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. Remove the need for a helper method to exit the language server

    @bendennis
    bendennis committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    00ed2e1 View commit details
    Browse the repository at this point in the history

  2. Match on Unhandled error explicitly and keep catch-all error case around

    @bendennis
    bendennis committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    a008f0b View commit details
    Browse the repository at this point in the history