Change path normalization strategy to not resolve symlinks #9330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't remember why I asummed that case is correct.
|
@pascalkuthe I added feature flags as you suggested. I don't know what to do with tests. It's bad to not write them for this non-trivial change, but testing is not easy too because we need to create a directory structure to test properly (it will do almost nothing on non-existent paths). What do you think? |
pascalkuthe
approved these changes
Jan 13, 2024
There was a problem hiding this comment.
I think yhe test cases you have are good enough. Great you added those!
Thanks for sticking with this trough the back and forth. This is a really dofficult problem and fiding a good solution that habdeles all constrains adequatly on all platforms isn't easy. It will be great to have symlinks working again!
pascalkuthe
added
C-bug
the-mikedavis
approved these changes
Jan 14, 2024
the-mikedavis
changed the title
dgkf
pushed a commit
to dgkf/helix
that referenced
this pull request
Jan 30, 2024
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
Vulpesx
pushed a commit
to Vulpesx/helix
that referenced
this pull request
Jun 7, 2024
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7458
Successor to #7658, which I messed up somehow.