Update some grammars to a commit where the license file is included #9279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
added
S-waiting-on-review
archseer
requested changes
Jan 9, 2024
runtime/queries/pod/highlights.scm
Outdated
Comment on lines
9
to
33
| (head_paragraph | ||
| (head_directive) @directive | ||
| (#eq? @directive "=head1") | ||
| (content) @markup.heading.1) | ||
| (head_paragraph | ||
| (head_directive) @directive | ||
| (#eq? @directive "=head2") | ||
| (content) @markup.heading.2) | ||
| (head_paragraph | ||
| (head_directive) @directive | ||
| (#eq? @directive "=head3") | ||
| (content) @markup.heading.3) | ||
| (head_paragraph | ||
| (head_directive) @directive | ||
| (#eq? @directive "=head4") | ||
| (content) @markup.heading.4) | ||
| (head_paragraph | ||
| (head_directive) @directive | ||
| (#eq? @directive "=head5") | ||
| (content) @markup.heading.5) | ||
| (head_paragraph | ||
| (head_directive) @directive | ||
| (#eq? @directive "=head6") | ||
| (content) @markup.heading.6) | ||
|
|
There was a problem hiding this comment.
This heading styling seems to have been reverted
There was a problem hiding this comment.
This is not yet resolved: the pattern on L7 should match =head1, =head2, etc. and use the markup.heading.1, markup.heading.2, etc. captures
runtime/queries/pod/highlights.scm
Outdated
| (interior_sequence | ||
| (sequence_letter) @character | ||
| (#eq? @character "B") | ||
| (content) @text.strong) |
There was a problem hiding this comment.
All of these @text styles are wrong and should use the @markup styles we had before
runtime/queries/pod/highlights.scm
Outdated
| (#not-match? @keyword "^=(head|over|item|encoding)") | ||
| (content) @string) | ||
|
|
||
| (verbatim_paragraph (content) @text.literal) |
the-mikedavis
added
S-waiting-on-author
Co-authored-by: Blaž Hrastnik <[email protected]>
|
Thanks for the review! I applied your suggested changes. |
runtime/queries/pod/highlights.scm
Outdated
Comment on lines
9
to
33
| (head_paragraph | ||
| (head_directive) @directive | ||
| (#eq? @directive "=head1") | ||
| (content) @markup.heading.1) | ||
| (head_paragraph | ||
| (head_directive) @directive | ||
| (#eq? @directive "=head2") | ||
| (content) @markup.heading.2) | ||
| (head_paragraph | ||
| (head_directive) @directive | ||
| (#eq? @directive "=head3") | ||
| (content) @markup.heading.3) | ||
| (head_paragraph | ||
| (head_directive) @directive | ||
| (#eq? @directive "=head4") | ||
| (content) @markup.heading.4) | ||
| (head_paragraph | ||
| (head_directive) @directive | ||
| (#eq? @directive "=head5") | ||
| (content) @markup.heading.5) | ||
| (head_paragraph | ||
| (head_directive) @directive | ||
| (#eq? @directive "=head6") | ||
| (content) @markup.heading.6) | ||
|
|
There was a problem hiding this comment.
This is not yet resolved: the pattern on L7 should match =head1, =head2, etc. and use the markup.heading.1, markup.heading.2, etc. captures
runtime/queries/pod/highlights.scm
Outdated
| (content) @markup.link.url) | ||
| (sequence_letter) @character | ||
| (#eq? @character "E") | ||
| (content) @string.escape) |
There was a problem hiding this comment.
Suggested change
| (content) @string.escape) | |
| (content) @string.special.escape) |
the-mikedavis
added
S-waiting-on-review
flinesse
pushed a commit
to flinesse/helix
that referenced
this pull request
Jan 25, 2024
…elix-editor#9279) Co-authored-by: Blaž Hrastnik <[email protected]> Co-authored-by: Michael Davis <[email protected]>
flinesse
pushed a commit
to flinesse/helix
that referenced
this pull request
Jan 25, 2024
…elix-editor#9279) Co-authored-by: Blaž Hrastnik <[email protected]> Co-authored-by: Michael Davis <[email protected]>
dgkf
pushed a commit
to dgkf/helix
that referenced
this pull request
Jan 30, 2024
…elix-editor#9279) Co-authored-by: Blaž Hrastnik <[email protected]> Co-authored-by: Michael Davis <[email protected]>
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
…elix-editor#9279) Co-authored-by: Blaž Hrastnik <[email protected]> Co-authored-by: Michael Davis <[email protected]>
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
…elix-editor#9279) Co-authored-by: Blaž Hrastnik <[email protected]> Co-authored-by: Michael Davis <[email protected]>
Vulpesx
pushed a commit
to Vulpesx/helix
that referenced
this pull request
Jun 7, 2024
…elix-editor#9279) Co-authored-by: Blaž Hrastnik <[email protected]> Co-authored-by: Michael Davis <[email protected]>
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
…elix-editor#9279) Co-authored-by: Blaž Hrastnik <[email protected]> Co-authored-by: Michael Davis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second part of #8691.
This PR should include all remaining grammars, that don't have license files. Except
tree-sitter-eexbecause upstream seems to be dead.I am unsure if the changes to the
scmfiles are 100% OK. I'd appreciate it if someone could double check them.