update history of a newly focused view #9271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change effectively reverts #3508 and #3633. When a view is changed we must make history commits (and ensure that the cursor is in view) for the newly focused view. Not the old view. These changes were originally introduced to fix mode switch hooks. However, the mode switch hooks have been moved elsewhere so that concern doesn't apply anymore. In particular, because modes are now editor wide and not per view and also because view switches now always reset the editor back to normal mode.
pascalkuthe
added
C-bug
dgkf
pushed a commit
to dgkf/helix
that referenced
this pull request
Jan 30, 2024
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
Vulpesx
pushed a commit
to Vulpesx/helix
that referenced
this pull request
Jun 7, 2024
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9181
This change effectively reverts #3508 and #3633.
When a view is changed we must make history commits (and ensure that
the cursor is in view) for the newly focused view. Not the old view.
We already create a history commit on view change so the old view should not need them (the current solution was inadequate for that case anyway since it didn't handle multiple view changes).
These changes were originally introduced to fix mode switch hooks.
However, the mode switch hooks have been moved elsewhere so that concern
no longer applies. In particular, because modes are now editor-wide
and not per view and also because view switches now always reset the
editor back to normal mode.
I tested all the reproduction cases from back in the day and unsurprisingly all of them do not cause any panic with this change.