Reduce logo sizes even more #9211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While reading through commits to helix I saw helix-editor#9106 and wondered if the relatively-new-to-me svgo would do better than -95B diff, indeed it does. Seeing as this file is "a minified file we're basically treating as binary" anyway I figured might as well minify it further.
the-mikedavis
approved these changes
Jan 2, 2024
pascalkuthe
approved these changes
Jan 2, 2024
woojiq
pushed a commit
to woojiq/helix
that referenced
this pull request
Jan 13, 2024
* Reduce logo.svg even more While reading through commits to helix I saw helix-editor#9106 and wondered if the relatively-new-to-me svgo would do better than -95B diff, indeed it does. Seeing as this file is "a minified file we're basically treating as binary" anyway I figured might as well minify it further. * Minimize all the svg logos
dgkf
pushed a commit
to dgkf/helix
that referenced
this pull request
Jan 30, 2024
* Reduce logo.svg even more While reading through commits to helix I saw helix-editor#9106 and wondered if the relatively-new-to-me svgo would do better than -95B diff, indeed it does. Seeing as this file is "a minified file we're basically treating as binary" anyway I figured might as well minify it further. * Minimize all the svg logos
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
* Reduce logo.svg even more While reading through commits to helix I saw helix-editor#9106 and wondered if the relatively-new-to-me svgo would do better than -95B diff, indeed it does. Seeing as this file is "a minified file we're basically treating as binary" anyway I figured might as well minify it further. * Minimize all the svg logos
Vulpesx
pushed a commit
to Vulpesx/helix
that referenced
this pull request
Jun 7, 2024
* Reduce logo.svg even more While reading through commits to helix I saw helix-editor#9106 and wondered if the relatively-new-to-me svgo would do better than -95B diff, indeed it does. Seeing as this file is "a minified file we're basically treating as binary" anyway I figured might as well minify it further. * Minimize all the svg logos
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
* Reduce logo.svg even more While reading through commits to helix I saw helix-editor#9106 and wondered if the relatively-new-to-me svgo would do better than -95B diff, indeed it does. Seeing as this file is "a minified file we're basically treating as binary" anyway I figured might as well minify it further. * Minimize all the svg logos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While going through commits to master for my favorite editor I noticed #9106 and wondered if the relatively-new-to-me-svg-optimizer svgo was used for this or not, it was not. SVGO is pretty neat and considering the logo.svg is "a minified file we're basically treating as binary" I figured might as well go all the way and also do the other svg files in the repo. So here is my tiny drive by contribution.
Before:
After:
A >50% reduction.