Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Hoon #9190

Merged
merged 6 commits into from
Feb 12, 2024
Merged

Add Hoon #9190

merged 6 commits into from
Feb 12, 2024

Conversation

ilyakooo0
Copy link
Contributor

reopening #9024

the-mikedavis
the-mikedavis reviewed Jan 2, 2024
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the highlights queries have disappeared (runtime/queries/hoon/highlights.scm)

@the-mikedavis the-mikedavis added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. A-language-support Area: Support for programming/text languages labels Jan 2, 2024
the-mikedavis
the-mikedavis reviewed Jan 3, 2024
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix the docs CI you'll need to run cargo xtask docgen and commit the changes

the-mikedavis
the-mikedavis previously approved these changes Jan 4, 2024
View reviewed changes
@the-mikedavis the-mikedavis changed the title Added Hoon Add Hoon Jan 4, 2024
@pascalkuthe
Copy link
Member

Needs to be rebas3d before merge

the-mikedavis
the-mikedavis previously approved these changes Feb 10, 2024
View reviewed changes
@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 10, 2024
pascalkuthe
pascalkuthe previously approved these changes Feb 12, 2024
View reviewed changes
@pascalkuthe
Copy link
Member

Oh looks like the comment about docgen wasn't addressed yet

@the-mikedavis
Copy link
Member

Ah actually that's my bad, I just mixed up the docs changes in the merge commit

@the-mikedavis the-mikedavis dismissed stale reviews from pascalkuthe and themself via bef7c2a February 12, 2024 14:02
@pascalkuthe pascalkuthe merged commit d7c7589 into helix-editor:master Feb 12, 2024
6 checks passed
cosmikwolf pushed a commit to cosmikwolf/helix that referenced this pull request Feb 26, 2024
@ilyakooo0 @the-mikedavis @cosmikwolf
Add Hoon (helix-editor#9190)
6679bad 
* Added Hoon

* Added highlights.scm

* Updated docs

* Update runtime/queries/hoon/highlights.scm

Co-authored-by: Michael Davis <[email protected]>

---------

Co-authored-by: Michael Davis <[email protected]>
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
@ilyakooo0 @the-mikedavis @postsolar
Add Hoon (helix-editor#9190)
350e456 
* Added Hoon

* Added highlights.scm

* Updated docs

* Update runtime/queries/hoon/highlights.scm

Co-authored-by: Michael Davis <[email protected]>

---------

Co-authored-by: Michael Davis <[email protected]>
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
@ilyakooo0 @the-mikedavis @mtoohey31
Add Hoon (helix-editor#9190)
cd4d733 
* Added Hoon

* Added highlights.scm

* Updated docs

* Update runtime/queries/hoon/highlights.scm

Co-authored-by: Michael Davis <[email protected]>

---------

Co-authored-by: Michael Davis <[email protected]>
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
@ilyakooo0 @the-mikedavis @Vulpesx
Add Hoon (helix-editor#9190)
9e7d964 
* Added Hoon

* Added highlights.scm

* Updated docs

* Update runtime/queries/hoon/highlights.scm

Co-authored-by: Michael Davis <[email protected]>

---------

Co-authored-by: Michael Davis <[email protected]>
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
@ilyakooo0 @the-mikedavis
Add Hoon (helix-editor#9190)
47999d2 
* Added Hoon

* Added highlights.scm

* Updated docs

* Update runtime/queries/hoon/highlights.scm

Co-authored-by: Michael Davis <[email protected]>

---------

Co-authored-by: Michael Davis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

@pascalkuthe pascalkuthe pascalkuthe approved these changes

Assignees
No one assigned
Labels
A-language-support Area: Support for programming/text languages S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilyakooo0 @pascalkuthe @the-mikedavis