Reduce logos-with-text sizes (-323B -322B) #9108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Current size: 6,602 B * Original size: 6,921 B * Add tab indentation (instead of 2/4 spaces) * Pretty Print by hand
* Current size: 6,930 B * Original size: 7,253 B * Add tab indentation (instead of 2/4 spaces) * Pretty Print by hand
|
Same as #9106, it'd be fine to minify these by stripping all unnecessary whitespace, the trailing newline and maybe stripping the inkscape attributes but I don't see any value in pretty printing. These files are formatted right now only because that's how inkscape exported them |
|
_"minify"_
after 2-3 days.
_"strip ink's attribs"_
stripping ink's attribs would be a destructive operation. rendering these
equivalent to a useless build adtifact, unable to be modified later. all
the work put into this will be gone. are u _sure_ u want to do that?
…On Tuesday, December 19, 2023, Michael Davis ***@***.***> wrote:
Same as #9106 <#9106>, it'd be
fine to minify these by stripping all unnecessary whitespace, the trailing
newline and maybe stripping the inkscape attributes but I don't see any
value in pretty printing. These files are formatted right now only because
that's how inkscape exported them
Message ID: ***@***.***>
|
also, the case with logo and logo-with-text is not same for minification - as here, there are 2 versions. the prettification makes it trivial to compare both the themes. 
rest the decision is onto u. |
Yeah this is not exactly high priority. Let's leave the files as they are, they're just used for display purposes for the README. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore(logo_dark): Pretty to reduce size by 323B ...
chore(logo_light): Pretty to reduce size by 322B ...