Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

book: Describe usage of .ignore and helix-specific ignore files in [editor.file-picker] section #9102

Merged
merged 1 commit into from
Dec 17, 2023

Conversation

novusnota
Copy link
Contributor

Hello, first-timer here 👋

Just wanted to add this since the documentation didn't mention much about .ignore files and did state nothing about helix-specific ignore files. But now, the [editor.file-picker] section has a nice addition to it:

image

This PR is relevant to #8099 and #7423.

@kirawi kirawi added the A-documentation Area: Documentation improvements label Dec 16, 2023
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@the-mikedavis the-mikedavis added the S-waiting-on-review Status: Awaiting review from a maintainer. label Dec 17, 2023
@pascalkuthe pascalkuthe merged commit a1a20d2 into helix-editor:master Dec 17, 2023
6 checks passed
book/src/configuration.md Show resolved Hide resolved
@daedroza
Copy link
Contributor

The local .ignore file picked not from .helix/ignore but simply .ignore, at least for me. Can someone please confirm?

@daedroza
Copy link
Contributor

But as per code it correctly reads from walk_builder.add_custom_ignore_filename(".helix/ignore");

dgkf pushed a commit to dgkf/helix that referenced this pull request Jan 30, 2024
@CheeseTurtle
Copy link

Why is this file called "ignore" and not ".ignore"?

@the-mikedavis
Copy link
Member

There's no reason for the file to be hidden twice. Also see #8099

mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-documentation Area: Documentation improvements S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants