Update tokyonight themes #9099
Update tokyonight themes #9099
Conversation
UntimelyCreation
force-pushed
the
tokyonight-update
branch
from
56edf92
to
446b49e
Compare
|
Very fair point, I just changed it back! |
the-mikedavis
added
A-theme
|
What were the changes from the upstreamed theme and could we merge some of the improvements? \cc @Finistere who has contributed this upstream (folke/tokyonight.nvim#409 -- wish we knew about it sooner!) |
|
What I did was use the upstream themes as a new baseline, and manually edit the file into something cleaner, mostly putting all colors into variables and dividing the file into sections in the spirit of the documentation and my previous themes. |
| "ui.text.info" = { bg = "bg-menu", fg = "fg" } | ||
| "ui.virtual.ruler" = { bg = "fg-gutter" } | ||
| "ui.virtual.whitespace" = { fg = "fg-gutter" } | ||
| "ui.virtual.inlay-hint" = { bg = "bg-inlay", fg = "teal" } |
There was a problem hiding this comment.
As someone that uses tokyo-night-storm and inlay-hints, i'd be relatively unhappy in having so strong colours for inlay-hints they should imo be as unnoticeable as possible. That's why i also made them have no bg as well as its fg-color to be the same as comments (which imo is the best way to handle it).
Any insight as to why make them so bold in colour?
There was a problem hiding this comment.
I just think of it the other way around. I like to make them stand out a bit from the base code as it is not part of it and is useful hinting, so I kept the upstream colors.
I also completely understand your point of view, and would be happy to leave them as they were before, which is "ui.virtual.inlay-hint" = { fg = "comment" } as you described.
There was a problem hiding this comment.
I wouldn't mind giving your idea a test-drive, there's always the ability to revert it anyway in the future :)
Maybe i would base the decision on whether it should be colorful / plain based on how it is handled in other themes? (i can't quite tell yet as i am using my own fork, i don't know what the current status quo is)
There was a problem hiding this comment.
After looking at the other themes, the inlay hints do seem to follow the more discreet approach, though there are both.
I'd say it's just a matter of personal preference.
As you seem OK with the change, let's leave it like this for now. There's always the option to change it back afterwards as you said!
| "function.macro" = { fg = "cyan" } | ||
| "keyword" = { fg = "cyan", modifiers = ["italic"] } | ||
| "function.special" = { fg = "cyan" } | ||
| keyword = { fg = "purple", modifiers = ["italic"] } |
There was a problem hiding this comment.
Why change the normal keyword to purple?
Just a question, no particular opinion on it as of right now.
There was a problem hiding this comment.
Coming from neovim, I try to stay as close as possible to folke's colors, as I intended when I first created the helix ones.
You can see this as a long due, small correction. I just didn't want to make a PR only for this, and thus waited for a more general update.
Update tokyonight themes (helix-editor#9099)
Hey there!
After seeing some auto-generated Helix themes by folke in his
neovimtokyonight repository, I decided to update Helix's themes accordingly.I carefully went through everything and landed on a clean, best-of-both-worlds result which I think is a nice improvement from the previous versions. I've added the two missing themes,
tokyonight_moonandtokyonight_day, and updated my email address.Here are some screenshots below.
If you see any mistake or improvement to make, feel free to contact me or make any changes!
Cheers!