Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version of Nix package #9013

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Fix version of Nix package #9013

merged 1 commit into from
Dec 8, 2023

Conversation

Dragonink
Copy link
Contributor

The version of the Nix package is using a placeholder (probably since bf7c4e1).

This PR fixes this issue by taking the package's version from the workspace Cargo.toml.

Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@the-mikedavis the-mikedavis added C-bug Category: This is a bug A-packaging Area: Packaging and bundling S-waiting-on-review Status: Awaiting review from a maintainer. labels Dec 6, 2023
@the-mikedavis the-mikedavis linked an issue Dec 7, 2023 that may be closed by this pull request
@archseer archseer merged commit 5109286 into helix-editor:master Dec 8, 2023
6 checks passed
@Dragonink Dragonink deleted the fix-nix-version branch December 8, 2023 23:13
Desdaemon pushed a commit to Desdaemon/helix that referenced this pull request Dec 11, 2023
dgkf pushed a commit to dgkf/helix that referenced this pull request Jan 30, 2024
nilium pushed a commit to nilium/helix that referenced this pull request Mar 10, 2024
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-packaging Area: Packaging and bundling C-bug Category: This is a bug S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nix: crane emitting a warning about version field
3 participants