Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make path changes LSP spec conformant #8949

Merged
merged 1 commit into from
Jan 28, 2024
Merged

make path changes LSP spec conformant #8949

merged 1 commit into from
Jan 28, 2024

Commits on Jan 25, 2024

  1. make path changes LSP spec conform

    Currently, helix implements operations which change the paths of files
    incorrectly and inconsistently. This PR ensures that we do the following
    whenever a buffer is renamed (`:move` and workspace edits)
    
    * always send did_open/did_close notifications
    * send will_rename/did_rename requests correctly
      * send them to all LSP servers not just those that are active for a
        buffer
      * also send these requests for paths that are not yet open in a buffer (if
        triggered from workspace edit).
      * only send these if the server registered interests in the path
    * autodetect language, indent, line ending, ..
    
    This PR also centralizes the infrastructure for path setting and
    therefore `:w <path>` benefits from similar fixed (but without didRename)
    pascalkuthe committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    8c23d3a View commit details
    Browse the repository at this point in the history