Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update rose_pine to be identical to main repo #8946

Merged
merged 1 commit into from
Dec 5, 2023
Merged

fix: update rose_pine to be identical to main repo #8946

merged 1 commit into from
Dec 5, 2023

Conversation

nshern
Copy link
Contributor

@nshern nshern commented Nov 29, 2023

@the-mikedavis the-mikedavis added A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer. labels Nov 30, 2023
@archseer archseer merged commit ab763b3 into helix-editor:master Dec 5, 2023
6 checks passed
@nshern nshern deleted the theme/update-rose-pine branch December 5, 2023 11:55
@LeoniePhiline
Copy link
Contributor

@nshern Could you have a look if these changes are intentional? I experience them as regressions.

image

(Using rose pine moon)

evanrichter pushed a commit to evanrichter/helix that referenced this pull request Dec 5, 2023
@nshern
Copy link
Contributor Author

nshern commented Dec 5, 2023

@nshern Could you have a look if these changes are intentional? I experience them as regressions.

image

(Using rose pine moon)

@LeoniePhiline I have only tested with Python. It may be that optimizing in one area may result in a regression in another? You are welcome to revert my PR if you find it to be a regression.

Desdaemon pushed a commit to Desdaemon/helix that referenced this pull request Dec 11, 2023
dgkf pushed a commit to dgkf/helix that referenced this pull request Jan 30, 2024
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants