Add handlebars language (for glimmer) #8779
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name = "handlebars" | ||
| injection-regex = "hbs" | ||
| roots = ["package.json"] | ||
| file-types = ["hbs"] |
There was a problem hiding this comment.
.hbs is just the handlebars extension, no? Templating languages are tricky to recognize because they can template any other language. AFAIK handlebars isn't HTML-specific so using an HTML-specific parser for all .hbs will give the wrong highlights for some files
There was a problem hiding this comment.
Yes .hbs is just handlebars, this grammar is made for ember.js's adaptation of handlebars (glimmer) templates which has some additional things e.g. components (tags starting with an uppercase letter), yield. html highlighting etc.
c0rydoras
force-pushed
the
feat/add-handlebars
branch
from
e80688f
to
bce1442
Compare
|
superseeded by #9902 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Handlebars Language (glimmer templates)
This adds support for glimmer
hbstemplates which are commonly used inember.js.It uses the grammar and queries from https://github.com/alexlafroscia/tree-sitter-glimmer
glimmer templates
nonglimmer templates