Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

theme: Add Theme poimandres #8759

Merged
merged 4 commits into from
Nov 12, 2023
Merged

theme: Add Theme poimandres #8759

merged 4 commits into from
Nov 12, 2023

Conversation

that-ambuj
Copy link
Contributor

A very underrated theme ported from vscode:

https://github.com/drcmda/poimandres-theme

image
Poimandres

image
Poimandres Storm

the-mikedavis
the-mikedavis reviewed Nov 8, 2023
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the only difference between storm and the normal variant is tuning the palette, can the storm one inherit the normal one insted? For example see tokyonight: https://github.com/helix-editor/helix/blob/master/runtime/themes/tokyonight.toml and https://github.com/helix-editor/helix/blob/master/runtime/themes/tokyonight_storm.toml

@that-ambuj
Copy link
Contributor Author

Thanks @the-mikedavis!

I didn't really remember to use inherits when I was porting the theme(It must've slipped off my mind). this would help theme and it's variant be more consistent!

@postsolar
Copy link
Contributor

postsolar commented Nov 8, 2023 •
edited
Loading

Looks awesome but could you please tweak something to make the selection more visible when cursorline is in use? It's barely visible unless extremely zoomed in
image

On the Storm variant it's good, it's only the regular one

@that-ambuj
Copy link
Contributor Author

Thanks for the comment @postsolar! I mainly use the storm variant and so I didn't bother much to test drive the regular variant 😅.

I will soon make the required changes.

@that-ambuj
Copy link
Contributor Author

that-ambuj commented Nov 9, 2023 •
edited
Loading

Hey @the-mikedavis, I have made some changes. Please merge this PR if all looks good to you.

@the-mikedavis the-mikedavis added A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer. labels Nov 12, 2023
@pascalkuthe pascalkuthe merged commit 23fea46 into helix-editor:master Nov 12, 2023
6 checks passed
danillos pushed a commit to danillos/helix that referenced this pull request Nov 21, 2023
@that-ambuj @danillos
theme: Add Theme poimandres (helix-editor#8759)
aae97f8 
* theme: Add Theme poimandres

* theme: inherit `poimandres_storm` from `poimandres` with minor tweaks

* fix(theme): rename `crossed-out` to `crossed_out`

* fix(theme:poimandres): improve contrast of selection color for regular variant
dgkf pushed a commit to dgkf/helix that referenced this pull request Jan 30, 2024
@that-ambuj @dgkf
theme: Add Theme poimandres (helix-editor#8759)
3ab75e7 
* theme: Add Theme poimandres

* theme: inherit `poimandres_storm` from `poimandres` with minor tweaks

* fix(theme): rename `crossed-out` to `crossed_out`

* fix(theme:poimandres): improve contrast of selection color for regular variant
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
@that-ambuj @mtoohey31
theme: Add Theme poimandres (helix-editor#8759)
7d4ffb2 
* theme: Add Theme poimandres

* theme: inherit `poimandres_storm` from `poimandres` with minor tweaks

* fix(theme): rename `crossed-out` to `crossed_out`

* fix(theme:poimandres): improve contrast of selection color for regular variant
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
@that-ambuj @Vulpesx
theme: Add Theme poimandres (helix-editor#8759)
3dcd7f9 
* theme: Add Theme poimandres

* theme: inherit `poimandres_storm` from `poimandres` with minor tweaks

* fix(theme): rename `crossed-out` to `crossed_out`

* fix(theme:poimandres): improve contrast of selection color for regular variant
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
@that-ambuj
theme: Add Theme poimandres (helix-editor#8759)
9c40cb6 
* theme: Add Theme poimandres

* theme: inherit `poimandres_storm` from `poimandres` with minor tweaks

* fix(theme): rename `crossed-out` to `crossed_out`

* fix(theme:poimandres): improve contrast of selection color for regular variant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

@pascalkuthe pascalkuthe pascalkuthe approved these changes

Assignees
No one assigned
Labels
A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@that-ambuj @postsolar @the-mikedavis @pascalkuthe