Add indent queries for scheme #8720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Triton171
force-pushed
the
scheme-indent-queries
branch
from
ae740c1
to
d01fb8e
Compare
the-mikedavis
approved these changes
Nov 8, 2023
the-mikedavis
added
S-waiting-on-review
pascalkuthe
approved these changes
Nov 8, 2023
danillos
pushed a commit
to danillos/helix
that referenced
this pull request
Nov 21, 2023
dgkf
pushed a commit
to dgkf/helix
that referenced
this pull request
Jan 30, 2024
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
Vulpesx
pushed a commit
to Vulpesx/helix
that referenced
this pull request
Jun 7, 2024
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add indent queries for scheme following this guide. The only thing which isn't fully implemented is the section about Lisp keywords: The queries handle them in a very simple way that sometimes underestimates the indent and the regex that matches keywords is definitely not complete. Still, it should be good enough to provide a good editing experience. Since I don't have any experience with Scheme/Lisp, it wouldn't hurt if someone more knowledgeable double-checked this though.
Since Lisp & Racket use the same grammar, I also just inherited the queries from scheme for them. For Racket, I added a default indent width, since there is a workaround in the queries that requires this (this workaround is a short-term solution but a better solution requires extending the indentation system).