Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

highlights: add type.parameter scope to several more languages #8718

Merged
merged 5 commits into from
Nov 6, 2023

Conversation

jmhain
Copy link
Contributor

@jmhain jmhain commented Nov 4, 2023

This is a follow-up to #8660 where I introduced the @type.parameter highlight scope to improve readability of generic code.

I've added the scope to several more languages:

  • TypeScript
  • Go
  • Haskell
  • OCaml
    • The above two don't need queries locals.scm since type variables are distinguished syntactically
  • Kotlin
    • There was a typo causing all types to be highlighted as builtins, so I fixed that as well

@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. A-language-support Area: Support for programming/text languages labels Nov 5, 2023
@pascalkuthe pascalkuthe merged commit f73e9a8 into helix-editor:master Nov 6, 2023
6 checks passed
@jmhain jmhain deleted the type-parameter-highlights-2 branch November 6, 2023 02:16
danillos pushed a commit to danillos/helix that referenced this pull request Nov 21, 2023
dgkf pushed a commit to dgkf/helix that referenced this pull request Jan 30, 2024
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
…-editor#8718)

* typescript

* go

* haskell

* ocaml

* kotlin (+ bugfix)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants