Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing license files for themes #8684

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

blinxen
Copy link
Contributor

@blinxen blinxen commented Oct 31, 2023

Some themes are based on MIT licensed themes / code. For this reason we need to add the original license text to be able to redistribute them. This is required for Fedora. I can add them myself in Fedora but having the files upstream makes it easier :D.

@blinxen
Copy link
Contributor Author

blinxen commented Oct 31, 2023

One theme does not have a license text (yet), so I also opened a PR there --> arturoalviar/serika-syntax#2

Copy link
Member

@pascalkuthe pascalkuthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking care of these things, I would be alright with keeping these files upstream

@pascalkuthe pascalkuthe added the S-waiting-on-review Status: Awaiting review from a maintainer. label Oct 31, 2023
@the-mikedavis the-mikedavis merged commit a069b92 into helix-editor:master Oct 31, 2023
6 checks passed
@the-mikedavis the-mikedavis added the A-documentation Area: Documentation improvements label Oct 31, 2023
danillos pushed a commit to danillos/helix that referenced this pull request Nov 21, 2023
dgkf pushed a commit to dgkf/helix that referenced this pull request Jan 30, 2024
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-documentation Area: Documentation improvements S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants