Add command to move files with LSP support

[yo-main]

close #4393

Allows to rename the active buffer by moving it to another path.

:move my_new_file.rs

Heavily based on all the work done in #5531 by @ontley and apply the suggestions

The PR seems dead and I would really like to see that feature come into helix :)

[archseer]

Can you keep the commit history and retain the original author then? If the PR is simply rebased or patched up I'd like to retain the original author so we properly attribute the work they've put in.

[ontley]

Can you keep the commit history and retain the original author then? If the PR is simply rebased or patched up I'd like to retain the original author so we properly attribute the work they've put in.

It's a big change compared to the code I had, this adds multiple lsp server support and it handles it properly unlike mine

[yo-main]

Can you keep the commit history and retain the original author then? If the PR is simply rebased or patched up I'd like to retain the original author so we properly attribute the work they've put in.

It's a big change compared to the code I had, this adds multiple lsp server support and it handles it properly unlike mine

Couldn't have manage the lsp thing without seeing how it was implemented in your PR :)
I managed to rebase my branch using your fork (that wasn't easy indeed 😄 I hope I didn't mess anything up)

[pascalkuthe]

this will probably need to wait for the next release, the current one is pretty close and I doubt we will merge new features before it

[cbr9]

Shouldn't this command allow to move files into directories by automatically adding the filename? Currently you have to manually type the filename if you want to move the buffer into a directory

[David-Else]

I just tried this with ltex-ls and immediate problems :(

hx hello.md

(create some text and save)

:move bye.md

if you use move too fast (before the language server has finished working I assume) you get an error like:

2023-11-10T16:12:02.351 helix_lsp::transport [ERROR] ltex-ls err <- "WARNING: Could not find document with URI 'file:///home/david/Downloads/bye.md'\n"
2023-11-10T16:12:02.353 helix_lsp::transport [ERROR] marksman err <- "[16:12:02 WRN] <MarksmanServer> Document not found: {\"uri\": \"{ uri = \\\"file:///home/david/Downloads/bye.md\\\"\\n  data = AbsPath \\\"/home/david/Downloads/bye.md\\\" }\", \"method\": \"textDocumentDidChange\"}\n"
2023-11-10T16:12:02.460 helix_lsp::transport [ERROR] marksman err <- "[16:12:02 WRN] <MarksmanServer> Document not found: {\"uri\": \"{ uri = \\\"file:///home/david/Downloads/bye.md\\\"\\n  data = AbsPath \\\"/home/david/Downloads/bye.md\\\" }\", \"method\": \"textDocumentDidChange\"}\n"
2023-11-10T16:12:02.460 helix_lsp::transport [ERROR] ltex-ls err <- "Nov 10, 2023 4:12:02 PM org.bsplines.ltexls.server.LtexTextDocumentService getDocument\n"
2023-11-10T16:12:02.460 helix_lsp::transport [ERROR] ltex-ls err <- "WARNING: Could not find document with URI 'file:///home/david/Downloads/bye.md'\n"

If you wait for ltex-ls to fully load before moving then the new file then you get 'no code actions available' but the text seems to have inherited the old underline errors?

Anyway, something funny is going on with the language server in this case. I am running ltex-ls and marksman. Cheers.

[pascalkuthe]

That is a language server problem. What we do on our side is quite trivial