Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight types and enum members in the rust prelude #8535

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Highlight types and enum members in the rust prelude #8535

merged 3 commits into from
Aug 14, 2024

Conversation

TheZoq2
Copy link
Contributor

@TheZoq2 TheZoq2 commented Oct 13, 2023 •
edited
Loading

A relatively simple change, but I like having the things in the prelude highlighted as builtin types

@TheZoq2 TheZoq2 changed the title Add everything from the rust prelude to the queries Highlight types and enum members in the rust prelude Oct 13, 2023
@kirawi
Copy link
Member

kirawi commented Oct 13, 2023 •
edited
Loading

We don't support #any-of I'm pretty sure, so it would have to use #match? instead. IMO this shouldn't merged and in the future would be better addressed with LSP semantic highlighting.

@archseer
Copy link
Member

any-of will soon be supported by upstream tree-sitter

@kirawi kirawi added S-waiting-on-review Status: Awaiting review from a maintainer. A-language-support Area: Support for programming/text languages labels Oct 17, 2023
the-mikedavis
the-mikedavis previously approved these changes Feb 10, 2024
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since #9317 we now support #any-of?

pascalkuthe
pascalkuthe reviewed Feb 10, 2024
View reviewed changes
runtime/queries/rust/highlights.scm Outdated Show resolved Hide resolved
runtime/queries/rust/highlights.scm Outdated Show resolved Hide resolved
@pascalkuthe pascalkuthe added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from a maintainer. labels Mar 17, 2024
@kirawi kirawi added S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 17, 2024
@TheZoq2
Copy link
Contributor Author

TheZoq2 commented Aug 8, 2024

Sorry, I switched away from helix for a while so this got stale. Updated with your comments now

@kirawi kirawi added S-waiting-on-review Status: Awaiting review from a maintainer. and removed S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. labels Aug 8, 2024
the-mikedavis
the-mikedavis previously approved these changes Aug 8, 2024
View reviewed changes
@the-mikedavis the-mikedavis added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from a maintainer. labels Aug 13, 2024
@TheZoq2 TheZoq2 mentioned this pull request Aug 14, 2024
Open
@the-mikedavis the-mikedavis removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 14, 2024
@the-mikedavis the-mikedavis added the S-waiting-on-review Status: Awaiting review from a maintainer. label Aug 14, 2024
@pascalkuthe pascalkuthe merged commit f9aae99 into helix-editor:master Aug 14, 2024
6 checks passed
GNUSheep pushed a commit to GNUSheep/helix that referenced this pull request Aug 19, 2024
@TheZoq2 @the-mikedavis @GNUSheep
Highlight types and enum members in the rust prelude (helix-editor#8535)
f2e55e6 
* Add some rust builtins

* rust queries: Add everything in the 2021 prelude

* Update runtime/queries/rust/highlights.scm

Co-authored-by: Michael Davis <[email protected]>

---------

Co-authored-by: Michael Davis <[email protected]>
kyruzic pushed a commit to kyruzic/helix that referenced this pull request Sep 27, 2024
@TheZoq2 @the-mikedavis @kyruzic
Highlight types and enum members in the rust prelude (helix-editor#8535)
5691626 
* Add some rust builtins

* rust queries: Add everything in the 2021 prelude

* Update runtime/queries/rust/highlights.scm

Co-authored-by: Michael Davis <[email protected]>

---------

Co-authored-by: Michael Davis <[email protected]>
plul pushed a commit to plul/helix that referenced this pull request Oct 13, 2024
@TheZoq2 @the-mikedavis @plul
Highlight types and enum members in the rust prelude (helix-editor#8535)
bb6cc48 
* Add some rust builtins

* rust queries: Add everything in the 2021 prelude

* Update runtime/queries/rust/highlights.scm

Co-authored-by: Michael Davis <[email protected]>

---------

Co-authored-by: Michael Davis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalkuthe pascalkuthe pascalkuthe approved these changes

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
A-language-support Area: Support for programming/text languages S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TheZoq2 @kirawi @archseer @the-mikedavis @pascalkuthe