Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime/themes: adding "ttox" theme #8524

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

tomasruud
Copy link
Contributor

I've made a small theme that should play well with most terminals, including Terminal.app on macOS. This theme has no explicit ui.background which means that if you were to use something like Terminal.app, it automatically handles dark and light mode for you.

Here are a couple of screenshots

light mode
dark mode

the-mikedavis
the-mikedavis previously approved these changes Oct 13, 2023
@the-mikedavis the-mikedavis added A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer. labels Oct 13, 2023
@boofexxx
Copy link
Contributor

like it but it's not possible to see the primary selection and the cursors on the selections

image

@tomasruud
Copy link
Contributor Author

You're right @boofexxx, I didn't think about that. I added a commit now with some improvements.

@pascalkuthe pascalkuthe merged commit 77ab792 into helix-editor:master Jan 8, 2024
6 checks passed
woojiq pushed a commit to woojiq/helix that referenced this pull request Jan 13, 2024
* runtime/themes: adding 'ttox' theme

* Improving primary selections
@tomasruud tomasruud deleted the theme-ttox branch January 22, 2024 09:26
dgkf pushed a commit to dgkf/helix that referenced this pull request Jan 30, 2024
* runtime/themes: adding 'ttox' theme

* Improving primary selections
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
* runtime/themes: adding 'ttox' theme

* Improving primary selections
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
* runtime/themes: adding 'ttox' theme

* Improving primary selections
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
* runtime/themes: adding 'ttox' theme

* Improving primary selections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants