Pin tree-sitter to the 0.20.10 release #8396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
added
A-dependencies
|
Sorry for my ignorance, but doesn't this mean the new Helix release will have an inferior 6 month old version of tree sitter? This Helix version will be the version the vast majority of people will be using for the next 3 or so months, so it would be quite a big deal? |
|
The only issue I know of with 0.20.10 that affects us is #7689 so I don't see this being a big deal |
|
And we have been blocking the helix release on TS releasing for close to two months now. At some point, we just have to stop waiting. Once TS releases its next version we can do a patch release. |
pascalkuthe
approved these changes
Sep 26, 2023
|
tree-sitter/tree-sitter#2669 (comment)
|
|
Now a month ago. We can't wait any longer so we'll merge this revert |
archseer
added a commit
that referenced
this pull request
Oct 26, 2023
We only reverted so that the latest release would use a stable tree-sitter version hosted on crates.io. We do want the improvements on nightly. This reverts commit 2ebcc4d.
danillos
pushed a commit
to danillos/helix
that referenced
this pull request
Nov 21, 2023
danillos
pushed a commit
to danillos/helix
that referenced
this pull request
Nov 21, 2023
We only reverted so that the latest release would use a stable tree-sitter version hosted on crates.io. We do want the improvements on nightly. This reverts commit 2ebcc4d.
dgkf
pushed a commit
to dgkf/helix
that referenced
this pull request
Jan 30, 2024
dgkf
pushed a commit
to dgkf/helix
that referenced
this pull request
Jan 30, 2024
We only reverted so that the latest release would use a stable tree-sitter version hosted on crates.io. We do want the improvements on nightly. This reverts commit 2ebcc4d.
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
We only reverted so that the latest release would use a stable tree-sitter version hosted on crates.io. We do want the improvements on nightly. This reverts commit 2ebcc4d.
Vulpesx
pushed a commit
to Vulpesx/helix
that referenced
this pull request
Jun 7, 2024
Vulpesx
pushed a commit
to Vulpesx/helix
that referenced
this pull request
Jun 7, 2024
We only reverted so that the latest release would use a stable tree-sitter version hosted on crates.io. We do want the improvements on nightly. This reverts commit 2ebcc4d.
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
We only reverted so that the latest release would use a stable tree-sitter version hosted on crates.io. We do want the improvements on nightly. This reverts commit 2ebcc4d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packagers downstream sometimes struggle with git dependencies so we want to switch to the published crate for the 23.09 (Helix) release. We can revert this and update the pinned commit after the release.