-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrolling Bufferline #8362
base: master
Are you sure you want to change the base?
Scrolling Bufferline #8362
Conversation
Rather than making the rendering configurable I would prefer we be opinionated and pick a sane default and have no config. IMO |
Like I mentioned, I am in favour of using |
as @the-mikedavis said we usually implement a single opiniated style in favour of adding a bunch of options. If somebody implements a second style in the future we simply won't accept the PR. |
As requested, I removed configurability for the bufferline behaviour. The bufferline now only scrolls when overflown. |
Hi all! Thanks for your hard work on helix. May I kindly ask if there's any update regarding this PR? |
I added markers on the left and right to indicate under and overflow as per #10868. |
Thanks for your continued work on this. I just tested this locally, but I cannot observe any scrolling behaviour by default. By the previous comments, I would have expected that this just works. |
Scrolling behaviour is default and non-configurable. |
This PR adds a scrolling bufferline.
Previously, anything overflown to the right wouldn’t be shown.
Now the active buffer tab will be scrolled as much to the center of the bar as possible, creating a scrolling effect.