Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling Bufferline #8362

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

CedricMeu
Copy link

@CedricMeu CedricMeu commented Sep 23, 2023

This PR adds a scrolling bufferline.
Previously, anything overflown to the right wouldn’t be shown.
Now the active buffer tab will be scrolled as much to the center of the bar as possible, creating a scrolling effect.

@kirawi kirawi added C-enhancement Category: Improvements A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer. labels Sep 23, 2023
@the-mikedavis
Copy link
Member

Rather than making the rendering configurable I would prefer we be opinionated and pick a sane default and have no config. IMO scroll is the best presentation, plus it aligns with other UIs like browsers.

@CedricMeu
Copy link
Author

Rather than making the rendering configurable I would prefer we be opinionated and pick a sane default and have no config. IMO scroll is the best presentation, plus it aligns with other UIs like browsers.

Like I mentioned, I am in favour of using scroll as the default.
Also overflow could be removed as no sane person would favour that over scroll nor wrap.
I am however hesitant on removing the configuration for the behaviour as other people might like wrapping over scrolling.
If we remove the option, someone down the line will probably reimplement it.

@pascalkuthe
Copy link
Member

as @the-mikedavis said we usually implement a single opiniated style in favour of adding a bunch of options. If somebody implements a second style in the future we simply won't accept the PR.

@CedricMeu
Copy link
Author

As requested, I removed configurability for the bufferline behaviour. The bufferline now only scrolls when overflown.

@dvdvgt
Copy link

dvdvgt commented Jun 17, 2024

Hi all! Thanks for your hard work on helix. May I kindly ask if there's any update regarding this PR?

@CedricMeu
Copy link
Author

I added markers on the left and right to indicate under and overflow as per #10868.
I used the ui.bufferline style as default for these, but am considering to add a style for these specifically. That should help differentiate them from the actual buffer tabs.

@dvdvgt
Copy link

dvdvgt commented Jun 28, 2024

Thanks for your continued work on this. I just tested this locally, but I cannot observe any scrolling behaviour by default. By the previous comments, I would have expected that this just works.

@CedricMeu
Copy link
Author

Thanks for your continued work on this. I just tested this locally, but I cannot observe any scrolling behaviour by default. By the previous comments, I would have expected that this just works.

Scrolling behaviour is default and non-configurable.
In order to develop locally, I just use cargo run and that seems to work for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants