Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crossterm: Handle 'hidden' modifier #8120

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

the-mikedavis
Copy link
Member

@the-mikedavis the-mikedavis commented Aug 30, 2023

Crossterm supports the 'hidden' SGR parameter but we previously didn't set the attribute when the "hidden" modifier was specified in a theme.

See #8082

Crossterm supports the 'hidden' SGR parameter but we previously didn't
set the attribute when the "hidden" modifier was specified in a theme.
@the-mikedavis the-mikedavis added C-enhancement Category: Improvements E-easy Call for participation: Experience needed to fix: Easy / not much A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer. labels Aug 30, 2023
@archseer archseer merged commit a276726 into helix-editor:master Aug 31, 2023
6 checks passed
@the-mikedavis the-mikedavis deleted the crossterm-hidden branch August 31, 2023 14:44
dgkf pushed a commit to dgkf/helix that referenced this pull request Jan 30, 2024
Crossterm supports the 'hidden' SGR parameter but we previously didn't
set the attribute when the "hidden" modifier was specified in a theme.
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
Crossterm supports the 'hidden' SGR parameter but we previously didn't
set the attribute when the "hidden" modifier was specified in a theme.
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Crossterm supports the 'hidden' SGR parameter but we previously didn't
set the attribute when the "hidden" modifier was specified in a theme.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related C-enhancement Category: Improvements E-easy Call for participation: Experience needed to fix: Easy / not much S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants